From 4e7e2a8f880e7c657b60462072552a0d4df12fc6 Mon Sep 17 00:00:00 2001 From: kkalev Date: Wed, 23 Jul 2003 14:34:09 +0000 Subject: [PATCH] * Only delete sessions which are not open in truncate_radacct. Bug noted by Evren Yurtesen * Add a user input tag in user_stats.php3 --- Changelog | 2 ++ bin/truncate_radacct | 2 +- htdocs/user_stats.php3 | 11 ++++++++--- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/Changelog b/Changelog index a16efeb..1766916 100644 --- a/Changelog +++ b/Changelog @@ -35,6 +35,8 @@ Ver 1.63: * Add 3 more help pages from Stadler Karel for Service-Type,Framed-Protocol and Filter-ID * Make all scripts use the mysql binary instead of DBI and make the sql password even if it is empty * Make log_badlogins work with usernames containing spaces +* Only delete sessions which are not open in truncate_radacct. Bug noted by Evren Yurtesen +* Add a user input tag in user_stats.php3 Ver 1.62: * Remove one sql query from user_admin which was not needed. * Instead of a query like "LIKE 'YYYY-MM-DD%'" use "AcctStopTime >= 'YYYY-MM-DD 00:00:00 AND AcctStopTime diff --git a/bin/truncate_radacct b/bin/truncate_radacct index b6b52c3..00c6a6c 100755 --- a/bin/truncate_radacct +++ b/bin/truncate_radacct @@ -29,7 +29,7 @@ $date = POSIX::strftime("%Y-%m-%d %T",$sec,$min,$hour,($mday - $back_days),$mon, print "$date\n"; $query = "LOCK TABLES $sql_accounting_table WRITE;"; -$query .= "DELETE FROM $sql_accounting_table WHERE AcctStopTime < '$date';"; +$query .= "DELETE FROM $sql_accounting_table WHERE AcctStopTime < '$date' AND AcctStopTime != 0;"; $query .= "UNLOCK TABLES;"; print "$query\n"; open TMP, ">/tmp/truncate_radacct.query" diff --git a/htdocs/user_stats.php3 b/htdocs/user_stats.php3 index 1892bb1..2182cba 100644 --- a/htdocs/user_stats.php3 +++ b/htdocs/user_stats.php3 @@ -40,6 +40,7 @@ else $order_attr = 'ConnNum'; if ($server != '' && $server != 'all') $server_str = "AND NASIPAddress = '$server'"; +$login_str = ($login) ? "AND UserName = '$login' " : ''; $selected[$order] = 'selected'; $selected[$sortby] = 'selected'; @@ -90,7 +91,7 @@ $link = @da_sql_pconnect($config); if ($link){ $search = @da_sql_query($link,$config, "SELECT * FROM $config[sql_total_accounting_table] - WHERE AcctDate >= '$start' AND AcctDate <= '$stop' $server_str + WHERE AcctDate >= '$start' AND AcctDate <= '$stop' $server_str $login_str ORDER BY $order_attr $order $limit;"); if ($search){ @@ -176,7 +177,9 @@ EOM; On Access Server: - + +User + - + + + -- 2.39.5